Show the price for the number of selected parts #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to check better what 20-180 for example means. Does that include 20 but not 180? |
chmorgan
reviewed
Jul 31, 2024
Bouni
force-pushed
the
better-price-column
branch
from
9382d87 to
3433d63
Compare
Bouni
force-pushed
the
better-price-column
branch
from
1e8828d to
d3c1538
Compare
|
I added the sum as well, which makes sense in my opinion:
|
|
But I found another issue, every part has a minimum price:
That piece of information is not in the parts database and if we want to show the correct price we would have to do an API call for every row in the results. So we will not be able to show the real price for most parts 🤷🏽♂️ |
Bouni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to make the messy price column more useful.
We now go through the price ranges and check for the number of selected parts (doable via the alike button fr example) in whch price range we are. Then return that as the price: